diff --git a/cediackermann/challenges/houseRobber/Solution.java b/cediackermann/challenges/houseRobber/Solution.java index 0b66ab3..8f62269 100644 --- a/cediackermann/challenges/houseRobber/Solution.java +++ b/cediackermann/challenges/houseRobber/Solution.java @@ -1,6 +1,5 @@ package cediackermann.challenges.houseRobber; - class Solution { public int rob(int[] nums) { int n = nums.length; @@ -12,9 +11,7 @@ class Solution { loot[1] = Math.max(nums[0], nums[1]); for (int i = 2; i < n; i++) { loot[i] = Math.max(loot[i - 1], nums[i] + loot[i - 2]); - System.out.println(loot[i]); } - - return loot[n - 1]; + return loot[n - 1]; } } diff --git a/cediackermann/challenges/romanToInt/BUILD b/cediackermann/challenges/romanToInt/BUILD index 021fe76..c7e59ca 100644 --- a/cediackermann/challenges/romanToInt/BUILD +++ b/cediackermann/challenges/romanToInt/BUILD @@ -4,7 +4,7 @@ package(default_visibility = ["//visibility:public"]) java_binary( name = "romanToInt", - main_class = "cediackermann.challenges.houseRobber.Main", + main_class = "cediackermann.challenges.romanToInt.Main", srcs = glob(["*.java"]), deps = [ ], diff --git a/cediackermann/challenges/romanToInt/Solution.java b/cediackermann/challenges/romanToInt/Solution.java index 2007ccc..64df9f4 100644 --- a/cediackermann/challenges/romanToInt/Solution.java +++ b/cediackermann/challenges/romanToInt/Solution.java @@ -5,7 +5,8 @@ import java.util.Map; class Solution { private final Map romanLetters = new HashMap<>(); - public Solution(){ + + public Solution() { romanLetters.put("I", 1); romanLetters.put("V", 5); romanLetters.put("X", 10); @@ -14,20 +15,23 @@ class Solution { romanLetters.put("D", 500); romanLetters.put("M", 1000); } + public int romanToInt(String s) { int solution = 0; for (int i = 0; i < s.length(); i++) { if (i + 1 <= s.length() - 1) { - if (this.romanLetters.get(Character.toString(s.charAt(i))) < this.romanLetters.get(Character.toString(s.charAt(i + 1)))) { - solution += this.romanLetters.get(Character.toString(s.charAt(i+1))) - this.romanLetters.get(Character.toString(s.charAt(i))); + if (this.romanLetters.get(Character.toString(s.charAt(i))) < this.romanLetters + .get(Character.toString(s.charAt(i + 1)))) { + solution += this.romanLetters.get(Character.toString(s.charAt(i + 1))) + - this.romanLetters.get(Character.toString(s.charAt(i))); i++; - } else{ + } else { solution += this.romanLetters.get(Character.toString(s.charAt(i))); - } - } else{ + } + } else { solution += this.romanLetters.get(Character.toString(s.charAt(i))); } } return solution; } -} +} \ No newline at end of file diff --git a/cediackermann/challenges/romanToInt2/BUILD b/cediackermann/challenges/romanToInt2/BUILD new file mode 100644 index 0000000..001b8b5 --- /dev/null +++ b/cediackermann/challenges/romanToInt2/BUILD @@ -0,0 +1,11 @@ +load("@rules_java//java:defs.bzl", "java_binary") + +package(default_visibility = ["//visibility:public"]) + +java_binary( + name = "romanToInt2", + main_class = "cediackermann.challenges.romanToInt2.Main", + srcs = glob(["*.java"]), + deps = [ + ], +) diff --git a/cediackermann/challenges/romanToInt2/Main.java b/cediackermann/challenges/romanToInt2/Main.java new file mode 100644 index 0000000..0229e98 --- /dev/null +++ b/cediackermann/challenges/romanToInt2/Main.java @@ -0,0 +1,10 @@ +package cediackermann.challenges.romanToInt2; + +public class Main { + public static void main(String[] args) { + Solution sol = new Solution(); + System.out.println( + sol.romanToInt("MCMXCIV")); + } + +} diff --git a/cediackermann/challenges/romanToInt2/Solution.java b/cediackermann/challenges/romanToInt2/Solution.java new file mode 100644 index 0000000..da6c06b --- /dev/null +++ b/cediackermann/challenges/romanToInt2/Solution.java @@ -0,0 +1,31 @@ +package cediackermann.challenges.romanToInt2; + +import java.util.HashMap; +import java.util.Map; + +class Solution { + private final Map romanLetters = new HashMap<>(); + + public Solution() { + romanLetters.put('I', 1); + romanLetters.put('V', 5); + romanLetters.put('X', 10); + romanLetters.put('L', 50); + romanLetters.put('C', 100); + romanLetters.put('D', 500); + romanLetters.put('M', 1000); + } + + public int romanToInt(String s) { + int solution = 0; + for (int i = 0; i < s.length() - 1; i++) { + if (this.romanLetters.get(s.charAt(i)) < this.romanLetters.get(s.charAt(i + 1))) { + solution -= this.romanLetters.get(s.charAt(i)); + } else { + solution += this.romanLetters.get(s.charAt(i)); + + } + } + return solution + romanLetters.get(s.charAt(s.length() - 1)); + } +} \ No newline at end of file diff --git a/cediackermann/challenges/romanToInt3/BUILD b/cediackermann/challenges/romanToInt3/BUILD new file mode 100644 index 0000000..7a2dd60 --- /dev/null +++ b/cediackermann/challenges/romanToInt3/BUILD @@ -0,0 +1,11 @@ +load("@rules_java//java:defs.bzl", "java_binary") + +package(default_visibility = ["//visibility:public"]) + +java_binary( + name = "romanToInt3", + main_class = "cediackermann.challenges.romanToInt3.Main", + srcs = glob(["*.java"]), + deps = [ + ], +) diff --git a/cediackermann/challenges/romanToInt3/Main.java b/cediackermann/challenges/romanToInt3/Main.java new file mode 100644 index 0000000..f82d54a --- /dev/null +++ b/cediackermann/challenges/romanToInt3/Main.java @@ -0,0 +1,10 @@ +package cediackermann.challenges.romanToInt3; + +public class Main { + public static void main(String[] args) { + Solution sol = new Solution(); + System.out.println( + sol.romanToInt("MCMXCIV")); + } + +} diff --git a/cediackermann/challenges/romanToInt3/Solution.java b/cediackermann/challenges/romanToInt3/Solution.java new file mode 100644 index 0000000..3f748ad --- /dev/null +++ b/cediackermann/challenges/romanToInt3/Solution.java @@ -0,0 +1,37 @@ +package cediackermann.challenges.romanToInt3; + +import java.util.HashMap; +import java.util.Map; + +class Solution { + private final Map romanLetters = new HashMap<>(); + + public Solution() { + romanLetters.put('I', 1); + romanLetters.put('V', 5); + romanLetters.put('X', 10); + romanLetters.put('L', 50); + romanLetters.put('C', 100); + romanLetters.put('D', 500); + romanLetters.put('M', 1000); + } + + public int romanToInt(String s) { + int solution = 0; + for (int i = 0; i < s.length(); i++) { + if (i + 1 <= s.length() - 1) { + if (this.romanLetters.get(s.charAt(i)) < this.romanLetters + .get(s.charAt(i + 1))) { + solution += this.romanLetters.get(s.charAt(i + 1)) + - this.romanLetters.get(s.charAt(i)); + i++; + } else { + solution += this.romanLetters.get(s.charAt(i)); + } + } else { + solution += this.romanLetters.get(s.charAt(i)); + } + } + return solution; + } +} \ No newline at end of file